This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
add eslint rule for no-target-blank in jsx, fix occurrences #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjwatson
approved these changes
Mar 14, 2017
| @@ -129,7 +134,14 @@ const Caption = (props) => { | |||
| <p><ErrorIcon /> Sorry, that name is already taken. Try a different name.</p> | |||
| <p className={ styles.helpText }> | |||
| If you think you should have sole rights to the name, | |||
| you can <a href={ FILE_NAME_CLAIM_URL } target='_blank'>file a claim</a>. | |||
| you can | |||
There was a problem hiding this comment.
I think you need {' '} here too.
earnubs
added a commit
that referenced
this pull request
Mar 20, 2017
earnubs
added a commit
that referenced
this pull request
Mar 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<a target=_blank />is considered a security risk, we don't really have user generated content but doesn't hurt to have the rule.More about
rel=noopenerhere: https://mathiasbynens.github.io/rel-noopener/Lint rule is defined here: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-target-blank.md