This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
Properly show spinner when user has no repositories #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
bartaz
commented
Mar 17, 2017
| const snapsLength = nextProps.snaps.snaps && nextProps.snaps.snaps.length; | ||
|
|
||
| if ((this.props.snaps.success !== nextProps.snaps.success) | ||
| || (snapsLength === 0)) { |
There was a problem hiding this comment.
Making sure user is redirected to select repositories view when all snaps are removed.
bartaz
commented
Mar 17, 2017
| // | ||
| // when snaps are loaded and user doesn't have any, they will be redirected | ||
| // to select repositories (so spinner won't be showing endlessly) | ||
| return !hasSnaps |
There was a problem hiding this comment.
In case of 'My repos' we don't care about isFetching or success.
If we don't know if user has any repos (initial state) we show spinner.
If we know they don't have any, we redirect to select repositories.
Otherwise we render repositories list. There is no spinner shown during polling.
katiefenn
approved these changes
Mar 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #507
Showing spinner on 'My repos' until snaps data is properly fetched.
If user has no repos (because they never added one or removed all of them) they will be redirected to select repositories.
Current solution has one case when it works a bit weird (may be considered a bug):
When user has some repositories and adds new one, then they move back from 'select repositories' to 'my repositories' they will see their old list of repos (without the new one) until list gets refreshed.
There is also no spinner of any kind (because we don't want to show spinner during polling).
So there is a visual delay between adding a repo and it being rendered no the list.