Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apps panel to models details page #658

Merged
merged 37 commits into from
Sep 1, 2020

Conversation

barrymcgee
Copy link
Contributor

@barrymcgee barrymcgee commented Aug 20, 2020

Done

  • Added apps panel to model details page

QA

  • Pull feature branch
  • Go to models page, click a model
  • On model details page, click an app
  • Verify side panel opens from the right as expected with correct model info

Fixes https://github.com/canonical-web-and-design/juju-squad/issues/1368

@webteam-app
Copy link

Demo starting at https://jaas-dashboard-658.demos.haus

@barrymcgee
Copy link
Contributor Author

Why is the charm name truncated? there's alot of space in that area

Notes go to the right, see design

Table row headings misalignment

This uses the same table alignment as the underlying model details view. We'll soon be replacing all these tables with the new rewrite from Vanilla.

@barrymcgee
Copy link
Contributor Author

Seems to be a delay when you click the left side of the panel to close the window, also feels janky compared to if you close the panel hitting the X button.

I removed errant, memory intensive, console.log which was causing this delay

@long-chung
Copy link

long-chung commented Sep 1, 2020

  • margin needs to be applied to the app name and the status in the header area
    Otherwise good to go

Screenshot 2020-09-01 at 15 32 43

Copy link
Contributor

@hatched hatched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @barrymcgee

The spacing around the header items is quite odd but this can be addressed in a follow-up (I'll create an issue).

Screen Shot 2020-09-01 at 9 30 03 AM

src/components/SlidePanel/SlidePanel.js Show resolved Hide resolved
@barrymcgee barrymcgee merged commit 50b4503 into canonical:master Sep 1, 2020
@barrymcgee barrymcgee deleted the apps-panel branch September 1, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants