Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the grecaptcha script in the newsletter sign up include #8977

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Include the grecaptcha script in the newsletter sign up include #8977

merged 1 commit into from
Jan 5, 2021

Conversation

anthonydillon
Copy link
Contributor

Done

Include the grecaptcha script in the newsletter sign up include

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/blog
  • See that the grecaptcha field appears in the Newsletter sign up box
  • Check on live it fails due to it being missing

Issue / Card

Fixes #8971

@webteam-app
Copy link

Demo starting at https://ubuntu-com-8977.demos.haus

pmahnke
pmahnke approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@pmahnke pmahnke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@anthonydillon anthonydillon merged commit fe58c4c into canonical:master Jan 5, 2021
@anthonydillon anthonydillon deleted the grecaptcha-for-newsletter-signups branch January 5, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmahnke pmahnke pmahnke approved these changes

Assignees
No one assigned
Labels
Released ✈️ Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sign up the newsletter from blog is broken
3 participants
@anthonydillon @webteam-app @pmahnke