Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype subset of components #2334

Closed
kwm14 opened this issue May 23, 2019 · 1 comment
Closed

Prototype subset of components #2334

kwm14 opened this issue May 23, 2019 · 1 comment
Assignees
Labels
Focal 20.04 20.04 Roadmap Cycle

Comments

@kwm14
Copy link
Contributor

kwm14 commented May 23, 2019

No description provided.

@kwm14 kwm14 added the Focal 20.04 20.04 Roadmap Cycle label Jun 25, 2019
@kwm14 kwm14 added this to the Iteration 19-30 milestone Jul 22, 2019
@kwm14 kwm14 removed this from the Iteration 19-30 milestone Jul 29, 2019
@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Aug 7, 2019

My original idea was to keep a config file that asigns each component a default theme, and build using that theme, per component. The core challenge with this is that unlike less, scss lacks dynamic imports. The scss maintainers are planning to address that with a new modules system, but that seems to be going nowhere fast. According to them:
image

  • if we don't plan to go beyond two themes for the foreseeable future, then wrapping imports in conditionals might work (not tested) almost like a dynamic import, e.g.:
@if($hr-default-theme == 'dark') { 
  @import 'hr-theme-dark'
}
  • or, we can just do it manually, by importing theme files and including them, as with patterns. But would this mean that out of the box we import everything? That would increase file size.
    If we opt to provide the files, but not include them by default, then you might be used to using hr.is-dark on say ubuntu.com, but in snapcraft where they import things individually, it would fail until you discover you need to import separately.

@lyubomir-popov lyubomir-popov added this to the Iteration 19-32 milestone Aug 8, 2019
@kwm14 kwm14 closed this as completed Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focal 20.04 20.04 Roadmap Cycle
Projects
None yet
Development

No branches or pull requests

2 participants