Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update styles of releases table #1206

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Update styles of releases table #1206

merged 1 commit into from
Oct 23, 2018

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Oct 15, 2018 •
edited
Loading

Fixes #1187

Updates visual style of releases table on Release page.
Design doc: https://docs.google.com/document/d/1DdWKGN22mppdse3jNmQe1p02ebimFO1ww94BXHD9Byg/edit?ts=5bab92e3#

QA

  • ./run or http://snapcraft.io-canonical-websites-pr-1206.run.demo.haus/
  • go to Releases page of any snap
  • look at the release table (it should have new look)
  • select some revisions to release
  • promote some channels
  • close some channels
  • check some snap with devmode revisions
  • all should work as before with new look

screen shot 2018-10-17 at 15 46 20

@webteam-app
Copy link

Starting demo at: http://snapcraft.io-canonical-websites-pr-1206.run.demo.haus/

@codecov-io
Copy link

codecov-io commented Oct 16, 2018 •
edited
Loading

Codecov Report

Merging #1206 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1206   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files          53       53           
  Lines        3443     3443           
=======================================
  Hits         2928     2928           
  Misses        515      515

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45aa35...d7ab93f. Read the comment docs.

@bartaz bartaz changed the title WIP: Update styles of release UI matrix Update styles of releases table Oct 16, 2018
Lukewh
Lukewh approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the commented out code and let back to const and it's good to go!

static/js/publisher/release/revisionsTable.js Outdated
const { releasedChannels, archs, tracks } = this.props;

let { releasedChannels, archs, tracks } = this.props;
//archs = archs.concat(archs).concat(archs).concat(['test']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably remove this if it was for testing while dev'ing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, every time I was explicitly skipping it from the commit I knew that there will be this one time when I'm gonna commit it.

@therealjuan-zz
Copy link
Contributor

Everything works from a QA standpoint but we will discuss in a meeting the UX side of things.

@bartaz
Copy link
Member Author

bartaz commented Oct 23, 2018

@therealjuan Can you have a look and give it a UX review when you have a moment?

@therealjuan-zz
Copy link
Contributor

UX reviewed and we already agreed next steps so 👍

@bartaz bartaz merged commit 6a2dbcd into canonical:master Oct 23, 2018
@bartaz bartaz deleted the release-ui-visual-redesign branch October 23, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukewh Lukewh Lukewh approved these changes

Assignees

@therealjuan-zz therealjuan-zz

Labels
Review: Code +1 Review: QA +1 Review: UX +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement updated visual design
5 participants
@bartaz @webteam-app @codecov-io @therealjuan-zz @Lukewh