Update the Vanilla dependency to v.1.6.3 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting demo at: http://snapcraft.io-pr-164.run.demo.haus/ |
|
@anthonydillon Yes, sorry. There should be both index.scss (for old snapcraft.io home page) and styles.css with new purely Vanilla styles. In recent merge index.scss was mistakenly removed. I created #165 to bring it back. This branch looks good, but let's first merge the index styles back. |
anthonydillon
force-pushed
the
upgrade-vanilla-to-v1.6.3
branch
from
f39eb43
to
e4ac3cd
Compare
|
@bartaz thanks, updated with your fix. |
|
@bartaz could you QA please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Update the Vanilla dependency to v.1.6.3
QA
./runthe minified file is not created and have a different filename (index.css vs styles.css)@bartaz @nottrobin do you know why?
Fixes canonical/vanilla-framework#1470