Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use on.available to communicate changes in alertmanager cluster, instead of emitting a custom ClusterChanged event #9

Closed
sed-i opened this issue Jun 16, 2021 · 1 comment
Closed

Use on.available to communicate changes in alertmanager cluster, instead of emitting a custom ClusterChanged event #9

sed-i opened this issue Jun 16, 2021 · 1 comment

Comments

@sed-i
Copy link
Contributor

sed-i commented Jun 16, 2021

I am still concerned that on a relation changed event this library can emit a ClusterChanged event while ConsumerBase emits a ProviderInvalid. If this does happen wouldn't this result in Prometheus adding an alertmanager into its config that is and "invalid" alertmanager ?

Originally posted by @balbirthomas in #7 (comment)
@sed-i sed-i mentioned this issue Jun 16, 2021
Merged
@sed-i
Copy link
Contributor Author

sed-i commented Sep 12, 2021

Not relevant anymore.
canonical/operator#606

@sed-i sed-i closed this as completed Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sed-i