Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ops.relation module from the framework #606

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Remove the ops.relation module from the framework #606

merged 3 commits into from
Sep 13, 2021

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented Sep 9, 2021

This PR reverses the changes introduced in #502. This may seem like a regression, though if required this functionality could be provided by a charm library. This change keeps Operator Framework more in line with its goal to behave more like the stdlib of Python charms, than a swiss-army knife.

@jnsgruk jnsgruk changed the title Remove the ops.relation part of the framework Remove the ops.relation module from the framework Sep 9, 2021
Copy link
Contributor

@pengale pengale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that this is the right direction to go here.

Copy link
Collaborator

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this indeed looks like a wrapper to functionality easily available in the core. If helpful, a better way to start its life is indeed as a charm lib.

@jnsgruk jnsgruk merged commit ecefbbf into canonical:master Sep 13, 2021
@jnsgruk jnsgruk deleted the remove-ops-relation branch September 13, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants