Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove double observe #114

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Remove double observe #114

merged 3 commits into from
Jan 17, 2023

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Jan 17, 2023

Ingress events were mistakenly observed twice.

@sed-i sed-i mentioned this pull request Jan 17, 2023
Merged
PietroPasotti
PietroPasotti approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Unclear why we were observing those events in the first place, indeed.

src/charm.py Show resolved Hide resolved
@sed-i sed-i merged commit 59db306 into main Jan 17, 2023
@sed-i sed-i deleted the feature/rm-double-observe branch January 17, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietroPasotti PietroPasotti PietroPasotti approved these changes

@lucabello lucabello Awaiting requested review from lucabello

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada

@rbarry82 rbarry82 Awaiting requested review from rbarry82

@dstathis dstathis Awaiting requested review from dstathis

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sed-i @PietroPasotti