Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use non-existent webhook as a placeholder #238

Merged
merged 1 commit into from Mar 29, 2024

Conversation

nobuto-m
Copy link
Contributor

Issue

Fixes: #237

Solution

The fake webhook fires the AlertmanagerNotificationsFailed alert continuously out of the box. Instead, use a blackhole receiver without any backend as a placeholder when no receiver is provided by an operator.

Context

[before patching]

global:
  http_config:
    tls_config:
      insecure_skip_verify: false
receivers:
- name: placeholder
  webhook_configs:
  - url: http://127.0.0.1:5001/
route:
  group_by:
  - juju_model
  - juju_application
  - juju_model_uuid
  group_interval: 5m
  group_wait: 30s
  receiver: placeholder
  repeat_interval: 1h

[after patching]

global:
  http_config:
    tls_config:
      insecure_skip_verify: false
receivers:
- name: placeholder
route:
  group_by:
  - juju_application
  - juju_model
  - juju_model_uuid
  group_interval: 5m
  group_wait: 30s
  receiver: placeholder
  repeat_interval: 1h

[After patching]
Screenshot from 2024-03-19 12-00-18

[The fix was applied in the middle of this timeline]
Screenshot from 2024-03-19 11-56-56

Testing Instructions

The steps are in #237.

  1. deploy COS and workload
  2. related COS with workload
  3. check alerts

Upgrade Notes

N/A

@nobuto-m
Copy link
Contributor Author

Copy link
Contributor

@sed-i sed-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @nobuto-m, I was not aware of this functionality!
Thanks for the change.

The fake webhook fires the AlertmanagerNotificationsFailed alert
continuously out of the box. Instead, use a blackhole receiver without
any backend as a placeholder when no receiver is provided by an
operator.

Fixes: canonical#237
@sed-i sed-i merged commit daabdd3 into canonical:main Mar 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AlertmanagerNotificationsFailed is fired continuously due to integration=webhook
2 participants