Use compute resource patch to limit resources #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As-is, itests will fail until canonical/microk8s-core-addons#73 is merged and released. |
sed-i
requested review from
Abuelodelanada,
rbarry82,
balbirthomas,
dstathis and
simskij
as code owners
|
We should probably wait for the lib to be published right? |
|
For the updates based on today's comments? Probably. The patch fixing the itests is great though |
dstathis
approved these changes
Aug 3, 2022
rbarry82
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Need to be able to limit resource usage of a charm.
Solution
limitsandrequests.Context
observability-libs/19.
Testing Instructions
kubectl describe statefulset -n welcome alertmanager-k8s.Release Notes
Use compute resource patch to limit resources.