Test add-streaming-sdk

[carkod]

Done

• Implementation of the Streaming SDK Test streaming endpoints #17 using example parameters (max resolution available on landscape mode)
• Unit and mocked integration tests

QA:

• Check out this feature branch
• Run the site using the command ./run serve
• Turn on the VPN
• View the site locally in your web browser at: http://0.0.0.0:8043/demo
• If you don't have access you need to ask for an invitation code and hit http://0.0.0.0:8043/login?invitation_code=XXXXX&next=/demo where XXXXX is where your invitation code goes.
• Once you log in, you should see the demo "Big Buggy Racing" game loading

A few considerations:

• The game may take some time to load. If it doesn't eventually load, you'd need to refresh the page.
• Current configuration uses keyboard instead of touch. Use arrow keys to control the buggy.
• Sometimes, it might be difficult to play the game, as there is some delay.

Issue / Cards:

• Tested Test streaming endpoints #17
• On this PR, an instance of the SDK was created and the example parameters were added Implement views for streaming API #18

[webteam-app]

Starting demo at: https://anbox-cloud-io-canonical-web-and-design-pr-50.run.demo.haus/

[codecov-io]

Codecov Report

Merging #50 into master will decrease coverage by 0.58%.
The diff coverage is 33.33%.

Impacted Files	Coverage Δ
tests/test_routes.py	100% <ø> (ø)	⬆️
webapp/app.py	57.74% <33.33%> (ø)	⬆️

[nottrobin]

Here are you simply testing internal logic of the MacaroonRequest library? We shouldn't test other people's code directly - that code should be tested by them, but even if it hasn't we should test it works through testing our usage of their module, rather than the module itself.

Again, I'd suggest removing this test.

[carkod]

Well, it's not really a library, it's just a module I took from snapcraft. It was not unit tested on that project.

[nottrobin]

If we think about what you're testing here - I think you're testing 2 things:

• That if you mock the API endpoint /1.0/login with responses, that it genuinely returns the data in the mock
• That the _api_request method successfully adds {ANBOXCLOUD_API_BASE} to the beginning of the URL it's passed, and that it returns the content of response.json()

To me, neither of these are particularly consequential. The first is effectively just making sure the responses library works, and the second is some very small internal logic of _api_request. I think if you're gonna add tests you should think about testing something more consequential.

[carkod]

I don't know how to improve this. Should I just do it with VCR?

[nottrobin]

I get this:

[nottrobin]

OK works for me in Chrome. In Firefox I get an error, as mentioned above. I think it's fine to merge this so we can do further testing though, since it's only accessible to people who know it's there and have invite codes.

[nottrobin]

Filed: #62