Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streaming: go fullscreen when starting a stream on a mobile device #79

Merged
merged 1 commit into from
Feb 19, 2020
Merged

streaming: go fullscreen when starting a stream on a mobile device #79

merged 1 commit into from
Feb 19, 2020

Conversation

aguadoenzo
Copy link
Contributor

@aguadoenzo aguadoenzo commented Feb 18, 2020 •
edited
Loading

Done

Enable fullscreen is a mobile device is detected
If better methods for detecting mobile devices are known, feel free to suggest it

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8043/
  • Run through the following QA steps
  • [List additional steps to QA the new features or prove the bug has been resolved]

@webteam-app
Copy link

Starting demo at: https://anbox-cloud-io-canonical-web-and-design-pr-79.run.demo.haus/

@aguadoenzo aguadoenzo mentioned this pull request Feb 19, 2020
Closed
@carkod carkod merged commit 801cae5 into canonical:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carkod carkod carkod approved these changes

Assignees

@deadlight deadlight

@carkod carkod

Labels
Project Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aguadoenzo @webteam-app @carkod @deadlight @pud-nats