chore: Fix pylint 2.16.2 complains #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylint 2.16.2 complains: ``` ************* Module apport.ui apport/ui.py:1567:20: W0101: Unreachable code (unreachable) ************* Module gtk.apport-gtk gtk/apport-gtk:678:8: W0101: Unreachable code (unreachable) ``` Remove the unreachable code. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
pylint 2.16.2 complains: ``` ************* Module apport.packaging_impl.rpm apport/packaging_impl/rpm.py:184:12: W0719: Raising too general exception: Exception (broad-exception-raised) ************* Module apport.crashdb_impl.launchpad apport/crashdb_impl/launchpad.py:397:16: W0719: Raising too general exception: Exception (broad-exception-raised) ``` Replace both instances with `NotImplementedError` which is more precise. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 81.74% 81.95% +0.21%
==========================================
Files 87 87
Lines 18193 18191 -2
==========================================
+ Hits 14871 14908 +37
+ Misses 3322 3283 -39
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
IMO codecov/patch can be ignored for this PR. |
schopin-pro
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint 2.16.2 complains:
Remove the unreachable code and replace both exceptions with
NotImplementedErrorwhich is more precise.