fix: Use URL for debug bug pattern URL #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bug_pattern_url` must be a URL and not only a file. Otherwise apport
will fail:
```
Traceback (most recent call last):
File "/usr/share/apport/apport-gtk", line 698, in <module>
app.run_argv()
File "/usr/lib/python3/dist-packages/apport/ui.py", line 868, in run_argv
return self.run_report_bug()
File "/usr/lib/python3/dist-packages/apport/ui.py", line 627, in run_report_bug
self.collect_info(symptom_script)
File "/usr/lib/python3/dist-packages/apport/ui.py", line 1624, in collect_info
bpthread.exc_raise()
File "/usr/lib/python3/dist-packages/apport/REThread.py", line 62, in exc_raise
raise self._exception[1].with_traceback(self._exception[2])
File "/usr/lib/python3/dist-packages/apport/REThread.py", line 37, in run
self._retval = self.__target(*self.__args, **self.__kwargs)
File "/usr/lib/python3/dist-packages/apport/report.py", line 1232, in search_bug_patterns
with urllib.request.urlopen(url) as request:
File "/usr/lib/python3.10/urllib/request.py", line 216, in urlopen
return opener.open(url, data, timeout)
File "/usr/lib/python3.10/urllib/request.py", line 503, in open
req = Request(fullurl, data)
File "/usr/lib/python3.10/urllib/request.py", line 322, in __init__
self.full_url = url
File "/usr/lib/python3.10/urllib/request.py", line 348, in full_url
self._parse()
File "/usr/lib/python3.10/urllib/request.py", line 377, in _parse
raise ValueError("unknown url type: %r" % self.full_url)
ValueError: unknown url type: '/tmp/bugpatterns.xml'
```
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 81.95% 81.95%
=======================================
Files 87 87
Lines 18197 18197
=======================================
Hits 14914 14914
Misses 3283 3283
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug_pattern_urlmust be a URL and not only a file. Otherwise apport will fail: