fix(tests): Fix check for full name in test_run_crash_anonymity #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property names are easier to read than the index numbers of the `pwd.getpwuid` response.
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 82.28% 82.28%
=======================================
Files 91 91
Lines 18367 18370 +3
=======================================
+ Hits 15113 15116 +3
Misses 3254 3254
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
The value `pw_gecos` contains a comma separated list where the first element might be the full user name. Split the first element from `pw_gecos` (if it is not empty) to check that the full name is not in the crash report. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
schopin-pro
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value
pw_gecoscontains a comma separated list where the first element might be the full user name. Split the first element frompw_gecos(if it is not empty) to check that the full name is not in the crash report.