Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum line length to 88 #196

Merged
merged 1 commit into from Jul 7, 2023
Merged

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Jul 7, 2023

Use the default line length from black. It reduces the pressure to keep the lines short, but still keeps the lines readable. See https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length for more reasoning.

Use the default line length from black. It reduces the pressure to keep
the lines short, but still keeps the lines readable. See
https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length
for more reasoning.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
@bdrung bdrung requested a review from schopin-pro July 7, 2023 09:28
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #196 (8953efb) into main (d9091e8) will decrease coverage by 9.96%.
The diff coverage is 67.53%.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   82.65%   72.69%   -9.96%     
==========================================
  Files          91       89       -2     
  Lines       18528    17802     -726     
==========================================
- Hits        15314    12941    -2373     
- Misses       3214     4861    +1647     
Impacted Files Coverage Δ
apport/crashdb_impl/debian.py 0.00% <0.00%> (ø)
apport/crashdb_impl/launchpad.py 0.00% <0.00%> (ø)
apport/packaging_impl/rpm.py 3.90% <0.00%> (ø)
apport_python_hook.py 56.30% <ø> (-22.69%) ⬇️
bin/apport-cli 40.00% <0.00%> (ø)
bin/apport-valgrind 60.91% <0.00%> (-14.95%) ⬇️
data/whoopsie-upload-all 25.19% <0.00%> (ø)
tests/integration/test_github.py 100.00% <ø> (ø)
tests/integration/test_recoverable_problem.py 100.00% <ø> (ø)
tests/system/test_python_crashes.py 31.46% <0.00%> (-65.17%) ⬇️
... and 55 more

... and 4 files with indirect coverage changes

Copy link
Contributor

@schopin-pro schopin-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm liking this a lot.

@schopin-pro schopin-pro merged commit 4a38b72 into canonical:main Jul 7, 2023
22 of 24 checks passed
@bdrung bdrung deleted the width branch July 7, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants