Deb822 prologue: refactorings #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 82.66% 82.69% +0.03%
==========================================
Files 91 91
Lines 18526 18558 +32
==========================================
+ Hits 15314 15347 +33
+ Misses 3212 3211 -1
|
bdrung
reviewed
Jul 12, 2023
bdrung
requested changes
Jul 13, 2023
This centralizes where we write single-line APT sources files in the tests.
We only implement the one-line style for now, but deb822 is coming.
…stic This commit splits out the gathering of the data from the actual heuristic implementation (which could hardly be simpler)
In the brave new world of deb822, there might not *be* a source.list file that we can rely on!! Note that this drops an early check for the existence of the source.list file. That check was of fairly low value in terms of validating input in the first place (source.list could be empty or full of garbage), and replacing it with the apt dir would even lower that value, as the dir itself could be empty. In addition to that, the exception raised is too generic to be truly useful.
For such a tiny string, it's surprisingly complicated to find out which are its components! This allows us to drastically reduce the complexity of create_ppa_source_from_origin()
This part is now self contained. Note that the new code is designed for future extension when the deb822 format support will be implemented.
bdrung
reviewed
Jul 13, 2023
…string This will make things easier when we switch to produce deb822 sources down the road, and makes the code in the main function a bit more readable.
bdrung
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various refactoring that will make it much easier to implement support for the APT deb822 source format.