Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apport-cli: Move gettext call out of f-string #207

Merged
merged 1 commit into from Jul 20, 2023

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Jul 20, 2023

intltool fails to extract the gettext call inside a f-string (see https://savannah.gnu.org/bugs/?61596). So move the gettext call out of
the f-string.

Fixes: 5a50433 ("refactor: Use f-strings everywhere")

@bdrung bdrung requested a review from schopin-pro July 20, 2023 09:59
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #207 (c934b5c) into main (6680b68) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files          91       91           
  Lines       18680    18680           
=======================================
  Hits        15464    15464           
  Misses       3216     3216           
Impacted Files Coverage Δ
bin/apport-cli 40.00% <100.00%> (ø)

intltool fails to extract the gettext call inside a f-string (see
https://savannah.gnu.org/bugs/?61596). So move the gettext call out of
the f-string.

Fixes: 5a50433 ("refactor: Use f-strings everywhere")
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
@schopin-pro schopin-pro merged commit 63345ff into canonical:main Jul 20, 2023
24 checks passed
@bdrung bdrung deleted the gettext branch July 20, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants