run-linters: Add --errors-only mode #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ease readability and future changes, move all code in individual functions. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Running the linters during the Ubuntu package build or in the autopkgtest is not wanted because newer linter versions can introduce new checks that can cause the build/autopkgtest to fail. So add an `--errors-only` mode that skips all formatting checks, but keeps the checks that can detect real errors. So run pylint with `--errors-only` and mypy. Bug: https://launchpad.net/bugs/2028881 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #215 +/- ##
=======================================
Coverage 82.81% 82.81%
=======================================
Files 91 91
Lines 18706 18706
=======================================
Hits 15492 15492
Misses 3214 3214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the linters during the Ubuntu package build or in the autopkgtest is not wanted because newer linter versions can introduce new checks that can cause the build/autopkgtest to fail.
So add an
--errors-onlymode that skips all formatting checks, but keeps the checks that can detect real errors. So run pylint with--errors-onlyand mypy.Bug: https://launchpad.net/bugs/2028881