Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Silence false inconsistent-return-statements #217

Merged
merged 1 commit into from Aug 8, 2023

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Aug 7, 2023

pylint 2.17.4 complains:

************* Module tests.integration.test_recoverable_problem
tests/integration/test_recoverable_problem.py:34:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
************* Module tests.integration.test_signal_crashes
tests/integration/test_signal_crashes.py:1175:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)

Silence those false positives.

pylint 2.17.4 complains:

```
************* Module tests.integration.test_recoverable_problem
tests/integration/test_recoverable_problem.py:34:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
************* Module tests.integration.test_signal_crashes
tests/integration/test_signal_crashes.py:1175:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
```

Silence those false positives.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
@bdrung bdrung requested a review from schopin-pro August 7, 2023 15:52
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #217 (7f18314) into main (bab7428) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   82.81%   82.81%           
=======================================
  Files          91       91           
  Lines       18706    18706           
=======================================
  Hits        15492    15492           
  Misses       3214     3214           
Files Changed Coverage Δ
tests/integration/test_recoverable_problem.py 100.00% <ø> (ø)
tests/integration/test_signal_crashes.py 90.74% <ø> (ø)

@schopin-pro schopin-pro merged commit 0caef9a into canonical:main Aug 8, 2023
24 checks passed
@bdrung bdrung deleted the pylint branch August 8, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants