setup: replace deprecated distutils by setuptools #223
Conversation
Codecov Report
@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 82.81% 82.83% +0.01%
==========================================
Files 91 92 +1
Lines 18737 18761 +24
==========================================
+ Hits 15517 15540 +23
- Misses 3220 3221 +1
|
bdrung
force-pushed
the
setuptools
branch
2 times, most recently
from
130c437
to
6924cdd
Compare
schopin-pro
force-pushed
the
setuptools
branch
from
6924cdd
to
fca6adc
Compare
|
The coverage on the new java plugin is pretty poor, I wasn't expecting that! |
|
The system-tests-installed should cover the new code. When running the install step in a jammy chroot, build_java and install_java are called, but they are not called in the CI. I fail to find the difference. |
`distutils.log` is deprecated. See https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Commit 90046b7 introduced the check for DistUtilsExtra >= 2.24 in 2011. Since `distutils.version` is deprecated, drop this version check. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
A future commit will port build_java to a custom setuptools module which should not be installed. To avoid installing such modules, explicitly list all packages that should be installed. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Using distutils directly is deprecated. Port `build_java_subdir` and the installation of the Java files to a setuptools plugin. packages needs to be specified for the `setup` call to avoid installing `setuptools_apport`. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
|
I figured it out: Do not ask me why the initial implementation did work sometimes. |
|
OK, I'll trust you on that one, since I just know enough about setuptools to not wanting to know more about it. |
Replace deprecated distutils by setuptools:
See also https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html