hookutils: skip checking stat for skipped DMI files and add unit test for apport.hookutils.attach_dmi #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DMI files `subsystem` and `uevent` will be always skipped. So checking their status with `os.stat` is not needed. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Add a unit test for `apport.hookutils.attach_dmi` that uses real data. This can be used as basis for fixing issues in `attach_hardware`. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Chris-Peterson444
approved these changes
Oct 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
==========================================
+ Coverage 82.81% 82.83% +0.02%
==========================================
Files 91 91
Lines 18737 18759 +22
==========================================
+ Hits 15517 15539 +22
Misses 3220 3220
|
schopin-pro
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DMI files
subsystemandueventwill be always skipped. So checking their status withos.statis not needed.Add a unit test for
apport.hookutils.attach_dmithat uses real data. This can be used as basis for fixing issues inattach_hardware(see #226).