Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove support for Upstart #228

Merged
merged 1 commit into from Oct 24, 2023
Merged

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Oct 24, 2023

Upstart is dead and not used any more. Remove the code for supporting Upstart. For backward compatibility do not remove the function but throw deprecation warnings instead.

Upstart is dead and not used any more. Remove the code for supporting
Upstart. For backward compatibility do not remove the function but throw
deprecation warnings instead.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #228 (d5853a4) into main (1f4a039) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   82.81%   82.94%   +0.13%     
==========================================
  Files          91       91              
  Lines       18737    18702      -35     
==========================================
- Hits        15517    15513       -4     
+ Misses       3220     3189      -31     
Files Coverage Δ
apport/hookutils.py 62.75% <100.00%> (+3.02%) ⬆️
tests/integration/test_hookutils.py 93.10% <ø> (-0.10%) ⬇️
tests/system/test_ui_gtk.py 100.00% <100.00%> (ø)
tests/system/test_ui_kde.py 96.64% <100.00%> (ø)
tests/unit/test_hookutils.py 100.00% <100.00%> (ø)

@schopin-pro schopin-pro merged commit d20d68b into canonical:main Oct 24, 2023
25 checks passed
@bdrung bdrung deleted the upstart branch October 24, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants