Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: Do not fail when pkg-config is missing #229

Merged
merged 1 commit into from Oct 25, 2023

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Oct 24, 2023

$ ./setup.py --help
Traceback (most recent call last):
  File "./setup.py", line 106, in <module>
    systemd_unit_dir = subprocess.check_output(
  File "/usr/lib/python3.10/subprocess.py", line 421, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.10/subprocess.py", line 503, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.10/subprocess.py", line 1863, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'pkg-config'

```
$ ./setup.py --help
Traceback (most recent call last):
  File "./setup.py", line 106, in <module>
    systemd_unit_dir = subprocess.check_output(
  File "/usr/lib/python3.10/subprocess.py", line 421, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.10/subprocess.py", line 503, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.10/subprocess.py", line 1863, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'pkg-config'
```

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #229 (4f7e791) into main (d20d68b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   82.98%   82.98%           
=======================================
  Files          92       92           
  Lines       18748    18748           
=======================================
  Hits        15558    15558           
  Misses       3190     3190           
Files Coverage Δ
setup.py 86.95% <100.00%> (ø)

@schopin-pro schopin-pro merged commit 917c562 into canonical:main Oct 25, 2023
25 checks passed
@bdrung bdrung deleted the pkg-config branch October 25, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants