Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: merge consecutive f-strings #230

Merged
merged 1 commit into from Oct 25, 2023

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Oct 25, 2023

Black merged several multi-line f-strings into one line leaving two f-string in the line that could be merged.

Fixes: 4a38b72 ("Increase maximum line length to 88")

Black merged several multi-line f-strings into one line leaving two
f-string in the line that could be merged.

Fixes: 4a38b72 ("Increase maximum line length to 88")
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #230 (99bc6a9) into main (8ca0648) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 70.00%.

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   82.98%   82.98%           
=======================================
  Files          92       92           
  Lines       18748    18748           
=======================================
  Hits        15558    15558           
  Misses       3190     3190           
Files Coverage Δ
apport/fileutils.py 84.92% <100.00%> (ø)
apport/report.py 85.43% <100.00%> (ø)
apport/ui.py 72.18% <100.00%> (ø)
problem_report.py 97.26% <ø> (ø)
tests/integration/test_report.py 92.39% <ø> (ø)
tests/integration/test_signal_crashes.py 90.74% <100.00%> (ø)
tests/integration/test_ui.py 97.44% <ø> (ø)
tests/system/test_packaging_apt_dpkg.py 98.92% <ø> (ø)
apport/crashdb.py 81.69% <0.00%> (ø)
apport/packaging_impl/apt_dpkg.py 84.27% <75.00%> (ø)
... and 1 more

@bdrung
Copy link
Collaborator Author

bdrung commented Oct 25, 2023

I suggest to ignore the complaining codecov/patch for this MR.

@schopin-pro schopin-pro merged commit 93cbca1 into canonical:main Oct 25, 2023
24 of 25 checks passed
@bdrung bdrung deleted the double-f-strings branch October 25, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants