test: remove dead system test code in test_python_crashes #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system tests call `_test_crash` always with `extracode` set and never set `scriptname`. Remove this dead code to increase code coverage. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 82.98% 82.99% +0.01%
==========================================
Files 92 92
Lines 18748 18744 -4
==========================================
- Hits 15558 15557 -1
+ Misses 3190 3187 -3
|
schopin-pro
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system tests call
_test_crashalways withextracodeset and never setscriptname. Remove this dead code to increase code coverage.