Correct get_id_url() for testing Launchpad instances and use launchpadlib.uris.lookup_web_root #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `get_id_url` hard-codes the URL to the production Launchpad instance. Use the same logic from `get_comment_url` to correct it. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
There are more Launchpad instances besides production, qastaging, and staging. Rely on `launchpadlib.uris.lookup_web_root` to map the short instance names to web root URLs. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 83.66% 83.69% +0.02%
==========================================
Files 93 93
Lines 18758 18754 -4
==========================================
+ Hits 15694 15696 +2
+ Misses 3064 3058 -6
|
schopin-pro
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
get_id_urlhard-codes the URL to the production Launchpad instance. Use the same logic fromget_comment_urlto correct it.There are more Launchpad instances besides production, qastaging, and staging. Rely on
launchpadlib.uris.lookup_web_rootto map the short instance names to web root URLs.Successfully run the Launchpad tests locally:
So the failing codecov/patch can be ignored.