Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run common hooks in alphabetical order #236

Merged
merged 1 commit into from Dec 11, 2023

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Oct 27, 2023

Run the common hooks in alphabetical order to make runs more predictable and to allow ordering hooks, e.g. for running a linux kernel hook after an ubuntu common hook (see bug #2018128).

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00561ca) 84.09% compared to head (ee66036) 84.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files          93       93           
  Lines       18887    18890    +3     
=======================================
+ Hits        15883    15886    +3     
  Misses       3004     3004           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@schopin-pro schopin-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can haz tests? It'd be nice to prove that the property you claim to add is actually present.

Run the common hooks in alphabetical order to make runs more predictable
and to allow ordering hooks, e.g. for running a linux kernel hook after
an ubuntu common hook (see bug #2018128[1]).

[1] https://launchpad.net/bugs/2018128
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
@bdrung
Copy link
Collaborator Author

bdrung commented Dec 11, 2023

Here you haz test_add_hooks_info extended to test the execution order. I tested that this extended test case will fail with the old code.

@schopin-pro schopin-pro merged commit e578014 into canonical:main Dec 11, 2023
25 checks passed
@bdrung bdrung deleted the ordering branch December 11, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants