Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add type hints to ProblemReport and Report #240

Merged
merged 1 commit into from Nov 5, 2023

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Oct 31, 2023

Add type hints to all methods of ProblemReport and Report but exclude those methods that needs reworking.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #240 (b397261) into main (c143c7c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   83.73%   83.73%           
=======================================
  Files          93       93           
  Lines       18768    18768           
=======================================
  Hits        15716    15716           
  Misses       3052     3052           
Files Coverage Δ
apport/report.py 85.54% <100.00%> (ø)
problem_report.py 97.27% <100.00%> (ø)

Add type hints to all methods of `ProblemReport` and `Report` but
exclude those methods that needs reworking.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
@schopin-pro schopin-pro merged commit f461526 into canonical:main Nov 5, 2023
25 checks passed
@bdrung bdrung deleted the type-hints branch November 7, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants