Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Import MagicMock from unittest.mock #243

Merged
merged 1 commit into from Nov 5, 2023

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Oct 31, 2023

Importing MagicMock from unittest.mock makes the code shorter by reducing the need to wrap long lines.

Importing `MagicMock` from `unittest.mock` makes the code shorter by
reducing the need to wrap long lines.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #243 (617f795) into main (c143c7c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   83.73%   83.75%   +0.01%     
==========================================
  Files          93       93              
  Lines       18768    18783      +15     
==========================================
+ Hits        15716    15731      +15     
  Misses       3052     3052              
Files Coverage Δ
tests/helper.py 98.41% <100.00%> (+0.02%) ⬆️
tests/integration/test_crashdb_launchpad.py 13.92% <100.00%> (+0.16%) ⬆️
tests/integration/test_hookutils.py 93.12% <100.00%> (+0.02%) ⬆️
tests/integration/test_report.py 92.40% <100.00%> (+<0.01%) ⬆️
tests/integration/test_signal_crashes.py 90.75% <100.00%> (+0.01%) ⬆️
tests/integration/test_ui.py 97.45% <100.00%> (+<0.01%) ⬆️
tests/system/test_ui_gtk.py 100.00% <100.00%> (ø)
tests/system/test_ui_kde.py 96.64% <100.00%> (+<0.01%) ⬆️
tests/unit/test_fileutils.py 100.00% <100.00%> (ø)
tests/unit/test_hooks_image.py 100.00% <100.00%> (ø)
... and 5 more

@schopin-pro schopin-pro merged commit bae5124 into canonical:main Nov 5, 2023
25 checks passed
@bdrung bdrung deleted the magic-mock branch November 7, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants