Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assert that a problem report exists where needed #246

Merged
merged 1 commit into from Nov 7, 2023

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Nov 2, 2023

Some UI methods rely on an existing problem report. Assert that they are present instead of trying to access the report.

Some UI methods rely on an existing problem report. Assert that they are
present instead of trying to access the report.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #246 (49229fe) into main (c143c7c) will increase coverage by 0.03%.
The diff coverage is 98.11%.

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   83.73%   83.77%   +0.03%     
==========================================
  Files          93       93              
  Lines       18768    18819      +51     
==========================================
+ Hits        15716    15766      +50     
- Misses       3052     3053       +1     
Files Coverage Δ
bin/apport-cli 40.23% <100.00%> (+0.23%) ⬆️
gtk/apport-gtk 77.69% <100.00%> (+0.16%) ⬆️
kde/apport-kde 83.38% <100.00%> (+0.05%) ⬆️
tests/integration/test_ui.py 97.51% <100.00%> (+0.06%) ⬆️
apport/ui.py 72.39% <92.30%> (+0.20%) ⬆️

@schopin-pro schopin-pro merged commit a40f5dc into canonical:main Nov 7, 2023
25 checks passed
@bdrung bdrung deleted the assert-report branch November 7, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants