report: Ignore missing COREDUMP_FILENAME #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 81.99% 82.29% +0.30%
==========================================
Files 94 94
Lines 19268 19289 +21
Branches 3096 3105 +9
==========================================
+ Hits 15798 15874 +76
+ Misses 2962 2915 -47
+ Partials 508 500 -8 ☔ View full report in Codecov by Sentry. |
Open the file on initialization of `CompressedFile` to ensure that the compressed file can be read to avoid failing later. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
If a systemd-coredump report points to a coredump file that does not
exist (any more), Apport will fail:
```
Traceback (most recent call last):
File "/usr/share/apport/apport", line 1244, in <module>
sys.exit(main(sys.argv[1:]))
^^^^^^^^^^^^^^^^^^
File "/usr/share/apport/apport", line 761, in main
return process_crash_from_systemd_coredump(options.systemd_coredump_instance)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/apport/apport", line 1240, in process_crash_from_systemd_coredump
return process_crash(report, real_user, report_owner)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/apport/apport", line 1146, in process_crash
info.write(reportfile)
File "/usr/lib/python3/dist-packages/problem_report.py", line 548, in write
self._write_binary_item_compressed_and_encoded(file, k)
File "/usr/lib/python3/dist-packages/problem_report.py", line 722, in _write_binary_item_compressed_and_encoded
self._write_binary_item_base64_encoded(
File "/usr/lib/python3/dist-packages/problem_report.py", line 629, in _write_binary_item_base64_encoded
for chunk in chunks:
File "/usr/lib/python3/dist-packages/problem_report.py", line 649, in _generate_compressed_chunks
yield from value.iter_compressed()
File "/usr/lib/python3/dist-packages/problem_report.py", line 194, in iter_compressed
with open(self.filename, "rb") as compressed_file:
^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/var/lib/systemd/coredump/core.tracker-extract.1000.92c6d53b71364e3286fd6011f3dad5e7.4441.1710845299000000.zst'
```
Ignore the missing coredump file and print a warning for it.
Bug: https://launchpad.net/bugs/2058380
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a systemd-coredump report points to a coredump file that does not exist (any more), Apport will fail:
Ignore the missing coredump file and print a warning for it.
Bug: https://launchpad.net/bugs/2058380