apport-kde: drop unused Dialog.addButton #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 82.53% 82.54% +0.01%
==========================================
Files 94 94
Lines 19366 19362 -4
Branches 3114 3114
==========================================
- Hits 15983 15982 -1
+ Misses 2887 2884 -3
Partials 496 496 ☔ View full report in Codecov by Sentry. |
bdrung
changed the title
mypy complains on Ubuntu 24.04 (noble): ``` kde/apport-kde:96: error: Incompatible return value type (got "QPushButton | None", expected "QPushButton") [return-value] ``` `Dialog.addButton` is not used. `ui_question_yesno` uses `QMessageBox.question`, `ui_question_choice` uses `ChoicesDialog`, and `ui_question_file` uses `QFileDialog.getOpenFileName`. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Add `python3-pyqt5` to linter container to allow mypy to check the PyQt code. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
schopin-pro
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy complains on Ubuntu 24.04 (noble):
Dialog.addButtonis not used.ui_question_yesnousesQMessageBox.question,ui_question_choiceusesChoicesDialog, andui_question_fileusesQFileDialog.getOpenFileName.