Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make return types more precise #333

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Jun 7, 2024

The argument types should be as generic as possible, but the return types should be as specific as possible.

The argument types should be as generic as possible, but the return
types should be as specific as possible.
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.40%. Comparing base (52560e6) to head (0c1c9ab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files          94       94           
  Lines       19334    19334           
  Branches     3113     3113           
=======================================
  Hits        15932    15932           
- Misses       2906     2907    +1     
+ Partials      496      495    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdrung bdrung requested a review from schopin-pro June 7, 2024 21:46
@schopin-pro schopin-pro merged commit b0a80f0 into canonical:main Jun 11, 2024
21 checks passed
@bdrung bdrung deleted the precise-return-types branch June 11, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants