test: properly mock os.uname calls #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
- Coverage 82.54% 82.53% -0.01%
==========================================
Files 94 94
Lines 19362 19353 -9
Branches 3114 3115 +1
==========================================
- Hits 15982 15973 -9
Misses 2883 2883
Partials 497 497 ☔ View full report in Codecov by Sentry. |
bdrung
changed the title
|
Tests are mad! |
schopin-pro
approved these changes
Jun 11, 2024
Use `unittest.mock.patch` to mock calls to `os.uname` instead of manually replacing and restoring `os.uname`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
unittest.mock.patchto mock calls toos.unameinstead of manually replacing and restoringos.uname.