pylint 3.2.2 fixes: initialize gdb_sandbox and fix UnboundLocalError in add_kernel_crash_info #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylint 3.2.2 complains: ``` bin/apport-retrace:515:15: E0601: Using variable 'gdb_sandbox' before assignment (used-before-assignment) ``` If `options.gdb_sandbox` evaluates to True, the architecture is the system architecture, and `sandbox` evaluates to False, `gdb_sandbox` will not be set.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 82.40% 82.53% +0.12%
==========================================
Files 94 94
Lines 19334 19366 +32
Branches 3113 3114 +1
==========================================
+ Hits 15932 15983 +51
+ Misses 2906 2886 -20
- Partials 496 497 +1 ☔ View full report in Codecov by Sentry. |
pylint 3.2.2 complains: ``` apport/report.py:878:71: E0606: Possibly using variable 'core' before assignment (possibly-used-before-assignment) ``` This case can be hit by analyzing a local kernel crash report with apport-retrace. `load_report` in `apport-retrace` loads the report with `binary="compressed"`. This leads to `VmCore` being an instance of `CompressedValue` which does not have a `find` method. Use the high-level interface `tempfile.NamedTemporaryFile` instead of `tempfile.mkstemp` and always write the `VmCore` content. Add support for writing `CompressedValue`. Add unit tests to (hopefully) cover all cases. Note: `add_kernel_crash_info` is only called by `apport-retrace`. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint 3.2.2 complains:
If
options.gdb_sandboxevaluates to True, the architecture is the system architecture, andsandboxevaluates to False,gdb_sandboxwill not be set.The case in
apport/report.pycan be hit by analyzing a local kernel crash report with apport-retrace.load_reportinapport-retraceloads the report withbinary="compressed". This leads toVmCorebeing an instance ofCompressedValuewhich does not have afindmethod.Use the high-level interface
tempfile.NamedTemporaryFileinstead oftempfile.mkstempand always write theVmCorecontent. Add support for writingCompressedValue. Add unit tests to (hopefully) cover all cases. Note:add_kernel_crash_infois only called byapport-retrace.