report: Fix retracing crashes on Ubuntu noble #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrung
force-pushed
the
fix-2067120-part2
branch
from
8c839f1
to
a2023f8
Compare
Calling `apport-retrace` with `--output` did not write the retraced report to the given output directory.
Retracing crashes from Ubuntu 24.04 (noble) can fail with (test case `test_retrace_system_sandbox_gdb_sandbox`): ``` ERROR: [Errno 2] No such file or directory: '/tmp/apport_sandbox_8s5bjkjo/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2' ``` Let `subprocess.run` find the correct path to `ld-linux-x86-64.so.2` by letting it search through all library paths. Add system tests for apport-retrace: One set of tests for retracing the same release and one set of tests for retracing crashes of a different release (in this case jammy). Bug-Ubuntu: https://launchpad.net/bugs/2067120
Installing `base-files` is not needed after applying the proper fix for finding `ld-linux-x86-64.so.2`. So revert installing `base-files` unless it was requested. In that case install it as first package to corretly set-up the usrmerge symlinks. Bug-Ubuntu: https://launchpad.net/bugs/2067120 Fixes: 52560e6 ("apport-retrace: install base-files first")
bdrung
force-pushed
the
fix-2067120-part2
branch
from
a2023f8
to
670083b
Compare
|
Codecov upload fails consistently. Let's close this PR and open a new one to see if Codecov will work then. |
|
Creating a new merge request does not help. |
|
Alright, forcing it through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retracing crashes from Ubuntu 24.04 (noble) can fail with (test case
test_retrace_system_sandbox_gdb_sandbox):Let
subprocess.runfind the correct path told-linux-x86-64.so.2by letting it search through all library paths.Add system tests for apport-retrace: One set of tests for retracing the same release and one set of tests for retracing crashes of a different release (in this case jammy).
Bug-Ubuntu: https://launchpad.net/bugs/2067120