Add a scripts_data provisioning variable
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, everything was handled as though we had two very separate and distinct folders for pre_scripts and post_scripts. However, in the profile configuration, there is only one `script_location` variable, that was later passed to both handlers for pre/post scripts, meaning we ended with two differents folders of the very same content.
Hyask
force-pushed
the
skia/var_crash_ignore_list
branch
from
f1569f1
to
6c53171
Compare
paride
approved these changes
Jan 18, 2024
Hyask
force-pushed
the
skia/var_crash_ignore_list
branch
from
6c53171
to
278d044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the effort to implement an ignore list for the
/var/crashtest. We need to be able to define the list of ignored crashes in each profile, so that means the scripts must have access to some data defined in the profile.This PR proposes a simple mechanism to implement that: introduce a
scripts_datavariable, that can contain any data structure, and will be pushed to the testbed as JSON under the namescripts_data.json, so its easy for any language to parse that file and access some data.Also, part of that work made me realize some inconsistencies and quirks in the code, which are what the two extra commits are for.
NOTE: as one of the commits renames a variable defined in the profiles, this PR needs to merge at the same time as this MP