Restart dex-auth pod on oidc-client relation changes #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knkski
requested review from
johnsca,
tvansteenburgh and
wallyworld
as code owners
johnsca
reviewed
Jan 29, 2020
charms/dex-auth/reactive/dex_auth.py
Outdated
| @@ -19,7 +19,9 @@ def charm_ready(): | |||
| layer.status.active("") | |||
|
|
|||
|
|
|||
| @when_any("layer.docker-resource.oci-image.changed", "config.changed") | |||
| @when_any( | |||
| "layer.docker-resource.oci-image.changed", "config.changed", "endpoint.oidc-client.changed" | |||
There was a problem hiding this comment.
The config.changed flag gets cleared automatically for legacy reasons, but I don't think that's necessarily true of the other two. Have you confirmed that this doesn't lead to a "restart on every update-status hook" issue?
Previously, any changes in config to oidc-gatekeeper weren't getting updated for dex-auth.
knkski
force-pushed
the
dex-relation-handling
branch
from
77631c3
to
1637487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any changes in config to oidc-gatekeeper weren't getting updated for dex-auth.