Various charm fixes. #993
alesstimecci.yaml
on: pull_request
lint
1m 6s
Build and Test
2m 19s
Annotations
10 errors
|
lint:
internal/debug/login.go#L176
Error return value of `r.ParseForm` is not checked (errcheck)
|
|
lint:
internal/debug/debug.go#L19
var `logger` is unused (unused)
|
|
lint:
internal/debug/debug.go#L36
S1011: should replace loop with `handlers = append(handlers, identity.ReqServer.Handlers(h.handler)...)` (gosimple)
|
|
lint:
idp/keystone/discharge_test.go#L115
type `tokenLoginRequest` is unused (unused)
|
|
lint:
idp/keystone/common_test.go#L43
SA1019: c.Defer is deprecated: in Go >= 1.14 use testing.TB.Cleanup instead. (staticcheck)
|
|
lint:
idp/keystone/discharge_test.go#L41
SA1019: c.Defer is deprecated: in Go >= 1.14 use testing.TB.Cleanup instead. (staticcheck)
|
|
lint:
idp/ldap/ldap_test.go#L160
Error return value of `i.Init` is not checked (errcheck)
|
|
lint:
idp/ldap/ldap_test.go#L252
Error return value of `i.Init` is not checked (errcheck)
|
|
lint:
idp/ldap/mockldap_test.go#L174
S1030: should use packet.Children[1].Data.String() instead of string(packet.Children[1].Data.Bytes()) (gosimple)
|
|
lint:
idp/ldap/discharge_test.go#L21
SA1019: c.Done is deprecated: in Go >= 1.14 this is no longer needed if using testing.TB.Cleanup. (staticcheck)
|