Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci/enable workflow #169

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Ci/enable workflow #169

merged 3 commits into from
Jan 25, 2024
+127 −9

Conversation

jneo8
Copy link
Contributor

@jneo8 jneo8 commented Jan 16, 2024 •
edited

  • Drop bionic

@jneo8 jneo8 force-pushed the ci/enable-workflow branch 4 times, most recently from cebde35 to e2a3698 Compare January 16, 2024 10:22
@jneo8 jneo8 force-pushed the ci/enable-workflow branch 3 times, most recently from b9563ce to ccf55d1 Compare January 24, 2024 07:13
dashmage
dashmage approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@dashmage dashmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add a bionic deprecation note here, it would be nice. But otherwise, LGTM :)

@jneo8
Copy link
Contributor Author

jneo8 commented Jan 25, 2024

If we add a bionic deprecation note here, it would be nice. But otherwise, LGTM :)

I add in the description.

@jneo8
ci: enable github workflow
478a301 
- Enable workflow on github
- Drop bionic
@jneo8 jneo8 merged commit e995946 into master Jan 25, 2024
3 checks passed
marcusboden pushed a commit to marcusboden/charm-nrpe that referenced this pull request Feb 8, 2024
@jneo8 @sudeephb @marcusboden
Ci/enable workflow (canonical#169)
212b5b6 
* Add CI workflow

* Handle submodules only via actions

* ci: enable github workflow

- Enable workflow on github
- Drop bionic

---------

Co-authored-by: sudeephb <sudeep.bhandari@canonical.com>
@rgildein rgildein deleted the ci/enable-workflow branch April 18, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashmage dashmage dashmage approved these changes

@sudeephb sudeephb sudeephb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jneo8 @dashmage @sudeephb