Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bundles when interacting with the store #128

Closed
facundobatista opened this issue Aug 19, 2020 · 5 comments
Closed

Handle bundles when interacting with the store #128

facundobatista opened this issue Aug 19, 2020 · 5 comments
Assignees
Labels
store Related to the interaction with the Store
Milestone

Comments

@facundobatista
Copy link
Contributor

facundobatista commented Aug 19, 2020

We need to handle bundles properly in all the operations related to the store.

Most of that should be ok already, but for sure we need to improve some details:

  • in the register command, give the option to register the name for a bundle. The idea is to provide a --type option that will allow the charm and bundle values (and possibly more in the future, like stack); this --type can be avoided if the project from where the command is issued can be identified as one or the other, otherwise it's mandatory.

  • in the names command, add a column with the type of the package.

  • in the build command, we should support a metadata.yaml not being there but a bundle.yaml: in that case just build a zip named .bundle with everything that is there (pretty much like we do for charms) but without building dependencies, or creating hooks/dispatch, etc. So in reality build will have two modes ("charm" and "bundle"), decided automatically after what is found in the project. Note also that some options are valid for the different modes (like --from) but others are not (like --entrypoint): in the latter cases we need to raise an error.

  • in the upload command, we need to rename current --charm-file to be --file (supporting both charm and bundle files), and improve what is automatically detected from the project where the command is issued (we can guess the name from a possible metadata.yaml, for example, but not from a bundle.yaml).

@facundobatista facundobatista added the store Related to the interaction with the Store label Aug 31, 2020
@facundobatista facundobatista added this to the 0.7.0 milestone Oct 14, 2020
@facundobatista facundobatista modified the milestones: 0.7.0, 0.8.0 Oct 28, 2020
@facundobatista
Copy link
Contributor Author

We went to a more explicit model regarding the commands...

These are the specific ones:

  • register-bundle
  • upload-bundle
  • release-bundle

These are still under study (if to be shared, or new ones be created):

  • revisions
  • status

OTOH, names if for "everything registered by the user", so it makes totally sense to work for "everything".

@facundobatista facundobatista modified the milestones: 0.8.0, 0.9.0 Jan 13, 2021
@hmlanigan
Copy link

Can we have a bundle init like we have a charm init?

@facundobatista
Copy link
Contributor Author

Everything landed. Still to work on some docs.

@facundobatista
Copy link
Contributor Author

Can we have a bundle init like we have a charm init?

No really needed, as normally we ask Juju to create the bundles, see here.

@facundobatista
Copy link
Contributor Author

We got docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
store Related to the interaction with the Store
Projects
None yet
Development

No branches or pull requests

2 participants