Support for bundles in the Upload command. #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
previously approved these changes
Feb 18, 2021
Comment on lines
290
to
292
| Push a charm or bundle to Charmhub where it will be verified for | ||
| conformance to the packaging standard. This command will finish | ||
| successfully once the package is approved by Charmhub. |
There was a problem hiding this comment.
Suggested change
| Push a charm or bundle to Charmhub where it will be verified for | |
| conformance to the packaging standard. This command will finish | |
| successfully once the package is approved by Charmhub. | |
| Push a charm or bundle to Charmhub where it will be verified. | |
| This command will finish successfully once the package is | |
| approved by Charmhub. |
charmcraft/utils.py
Outdated
Comment on lines
73
to
77
| """Convert the string to Path and verify that is a useful file path. | ||
|
|
||
| It checks that the file exists and it's readable, and that it's actually a | ||
| file. Also the `~` is expanded to the user's home. | ||
| """ |
There was a problem hiding this comment.
Suggested change
| """Convert the string to Path and verify that is a useful file path. | |
| It checks that the file exists and it's readable, and that it's actually a | |
| file. Also the `~` is expanded to the user's home. | |
| """ | |
| """Return a valid Path with user name expansion for filepath. | |
| CommandError is raised if filepath is not a valid file or is not readable. | |
| """ |
There was a problem hiding this comment.
better, thanks!
sergiusens
previously approved these changes
Feb 18, 2021
sergiusens
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #128.
Fixes #77.