-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pack bundle with overlay (support more than a single document in the stream) #549
Comments
This functionality is super important for LMA 2. We intend to ship LMA 2 as fundamentally "an appliance" in a self-contained Juju model, which means that being able to define the offers upfront in the bundle is a far, far better UX that not doing so. |
Turns out that, for now, this is limitation was meant to be there, as overlays are mostly specific to a deployment (see juju/charmstore#884 ). Nevertheless, I feel very strongly that default offers should be a valid exception to the rule. |
At least charmcraft should not crash trying to read the file. Probably we should |
I agree that |
As it turns out my understanding of how the |
We will fix charmcraft, to not crash in this situation, and add a linter that will detect that the bundle has overlays, and refuse to pack if so. But, as linters can be ignored, we will wait for Charmhub to start rejecting this kind of bundles (tracked here). |
I'm trying to pack this bundle, which has multiple documents (bundle + overlay):
Ref: charm-bundles/1058
The text was updated successfully, but these errors were encountered: