Reject uploads of bundles containing overlays #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: CI bails out complaining the mongo has shut down |
|
@mhilton I have performed an audit of the code in the gobwas/glob that we have added to our dependencies and found no red flags. More specifically, the package only deals with string comparisons and performs no I/O (files, sockets etc.). For additional context: the package is used by juju when a local charm is uploaded to a controller to filter the charm archive files (e.g. the '.tox/' folder contents) before re-packaging the charm archive (we landed this as a fix for https://bugs.launchpad.net/juju/+bug/1813799) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the charmstore to detect attempts to upload bundles whose
bundle.yamlentry contains multiple documents and return an error to indicate that multi-document bundles are not currently supported by the charmstore.On a side-note, the charm.v6 version imported by this PR includes helpers for dealing with multi-doc bundles (
LocalBundleDataSource,StreamBundleDataSourceandReadAndMergeBundleData). This should make it easier to update the charmstore code so it can deal with multi-doc bundles in the future if that's something we want to do.