Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduce the charm's name from the file's included metadata, not its name #77

Closed
facundobatista opened this issue Jul 14, 2020 · 0 comments · Fixed by #246
Closed

Deduce the charm's name from the file's included metadata, not its name #77

facundobatista opened this issue Jul 14, 2020 · 0 comments · Fixed by #246
Assignees
@facundobatista
Labels
build Related to the build process
Milestone
0.9.0

Comments

@facundobatista
Copy link
Contributor

Currently in the upload command, if a charm binary is pointed out to upload, we deduce the charm's name from the pointed out binary name.

We should open that binary (unzip it), get its included metadata.yaml, parse it, and get the name from there.
@facundobatista facundobatista mentioned this issue Jul 14, 2020
Merged
@facundobatista facundobatista added the build Related to the build process label Aug 31, 2020
@chipaca chipaca added this to the 0.7.0 milestone Oct 14, 2020
@facundobatista facundobatista modified the milestones: 0.7.0, 0.8.0 Oct 28, 2020
@facundobatista facundobatista modified the milestones: 0.8.0, 0.9.0 Jan 13, 2021
@facundobatista facundobatista self-assigned this Feb 5, 2021
@facundobatista facundobatista mentioned this issue Feb 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facundobatista facundobatista

Labels
build Related to the build process
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Support for bundles in the Upload command. facundobatista/charmcraft
2 participants
@facundobatista @chipaca