a couple of fixes for tests #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmclark
approved these changes
Aug 19, 2020
|
|
||
| import pytest | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True, scope="session") | ||
| def tmpdir_under_tmpdir(tmpdir_factory): | ||
| tempfile.tempdir = str(tmpdir_factory.getbasetemp()) |
There was a problem hiding this comment.
I was trying to understand how this works based on tmpdir_factory examples -- can all the tests using this fixture (which should be all of them due to autouse=True) access tempfile.tempdir?
Looking at docs, it seems as though when tempfile.tempdir is not None, it is only used as the dir default for other tempfile functions and it was unclear to me if it is useful outside of the context of the tempfile module: [1]
[1] https://docs.python.org/3/library/tempfile.html#tempfile.tempdir
There was a problem hiding this comment.
this change is exactly so charmcraft's calls to tempfile.mkstemp (in logsetup) use the test's tempdir instead of the default; this is the change that fixes #105.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #105