feat(config): support type:secret in config.options
#1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
approved these changes
Apr 3, 2024
syu-w
reviewed
Apr 3, 2024
syu-w
approved these changes
Apr 3, 2024
tonyandrewmeyer
changed the title
type:secret in config.options
syu-w
changed the title
type:secret in config.optionstype:secret in config.options
|
I (foolishly!) made the same mistake here as on the earlier PR and did the GitHub UI "update" without picking the address to associate that with. I've now signed the CLA with my personal address also, so I think if that action is re-run it should pass? |
|
@tonyandrewmeyer I'm not sure why it's still not liking it. If you want you can rebase and force-push; otherwise I'll check tomorrow and see what we can do. |
This makes a few related changes: 1. Extensions are applied on the rawest charmcraft.yaml data we have 2. Charms with a "bases" key (not just bundles) get a default part. 3. Always expect a dictionary for parts.
tonyandrewmeyer
force-pushed
the
config-type-secret-main
branch
from
3f5b420
to
701a7b9
Compare
|
Thanks again @tonyandrewmeyer ! This is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Juju 3.1, the
config.optionssection ofcharmcraft.yaml(or the olderconfig.yaml) has supported atypevalue ofsecret(for user secrets). This is missing from the documentation right now, but the Juju team are working on fixing that.This PR adds support for
type: secretin config options.